feat(stellar): add signer interface for passkey stealth key derivation - #153
Merged
truthixify merged 1 commit intoJul 28, 2026
Conversation
|
@collinsezedike Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merge conflicts appeared from other sdk PRs that landed just before yours. Rebase against develop and force-push. |
collinsezedike
force-pushed
the
feat/stellar-passkey-stealth-signer
branch
from
July 27, 2026 20:51
c61c69d to
4f9e2b4
Compare
Contributor
Author
|
Rebased against develop and force-pushed. Resolved conflicts in CHANGELOG.md and packages/sdk-react/src/hooks.ts (the latter conflicted with the useScanner extraction from #146 — kept the new import shape and just added the signer-related imports/exports on top). |
Contributor
|
Merged. Passkey abstraction lands cleanly now, thanks for pushing through the earlier conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StellarStealthSignerinterface (signMessage(message): Promise<Uint8Array>) andderiveStealthKeysFromSigner()insrc/chains/stellar/signer.ts/keys.ts, so stealth key derivation no longer assumes a synchronous Freighter-shaped ed25519 signature.FreighterStealthSignerwraps the existing Freighter-style wallet API; the rawderiveStealthKeys(signature)path is unchanged.WebAuthnPasskeyStealthSigneris a reference passkey adapter. WebAuthnget()assertions aren't deterministic across sessions (fresh ECDSA nonce, changing counter/clientDataJSON), so instead of hashing the assertion signature it uses the WebAuthn Level 3prfextension, which is deterministic for a given credential and salt.useStellarStealthKeys()in@wraith-protocol/sdk-reactgainedgenerateFromSigner()alongside the existinggenerate().docs/chains/stellar-stealth-signers.md, changelog entry under the upcoming release.Closes #121.
Semver
Additive-only: new exports (
StellarStealthSigner,deriveStealthKeysFromSigner,FreighterStealthSigner,WebAuthnPasskeyStealthSigner) plus a new hook method. No existing signature or behavior changes.Test plan
pnpm build(root andsdk-react)pnpm test— full Stellar suite (797 passed) andsdk-reactsuite passtest/chains/stellar/signer.test.ts: Freighter path unchanged, passkey mock derives identical keys across two independent sessions, different credentials diverge, missing PRF / missing credentials container throwpnpm format:check